| Age | Commit message (Collapse) | Author |
|---|
|
|
|
Includes some enhancements and updates on how arguments/options are
parsed.
Passing `-d /target/dir` you can specify an output directory:
`./yt-dlp-best -d /home/$USER/Videos/ 'https://example.com?my=video'`
The file will first be written to a temporary directory (leveraging
mktemp if available on the system; else a default directory created in
/tmp/) then moved to your target directory.
This will allow for targetting a slower / networked drive and avoid
both the video & audio write and merge happening over the networked
disk.
Future improvement would be to add a -t to allow passing in a specific
temp dir.
|
|
Use getops to parse multiple args: -h (help), -s (sub titles) and -y
to skip checking the command before running (pre-existing).
|
|
-y can be passed now as the first argument such as:
yt-dlp-best -y "URL"
this is a naive implementation given its positionally required as well
as directly forcing into the answer check flow rather than separating
out the execution logic into a subfunction and calling it. Technically
speaking this executes in bash so that'd be fine. I just figured this
would be easier to follow down the line. idk.
|
|
While this bug didn't cause any issues (that we've found) it muddled
the output for the user. This seemed to happen more on older/lower
maximum quality videos.
We also put "mp4" in a variable "DESIRED_FMT" with the intention of
making this a parameter the user can set. However, we're now moving
into "just read the params for the script" territory
|
|
The variable wasn't wrapped in quotes in echo and reversing the lines
made things much more clear
|
|
Known quirks:
if the best two formats are mp4 the FMT_LINE will have 2 lines in it;
it currently assumes the top two are webm and mp4, but this is a quick
fix I'll likely do in a later commit. (just swap the grep and tail -n
1)
We just force m4a as the audio but this may not be optimal; you can
get the audio formats and merging the two best may be the best
situation especailly for audio focused things like a music video or
something.
|