From 5c2c95a8970e058814efc37b083dcda2f44bbda8 Mon Sep 17 00:00:00 2001 From: wn_ Date: Sun, 27 Apr 2025 14:53:53 +0000 Subject: Remove unused 'PluginHost::HOOK_FORMAT_ARTICLE_CDM'. PHPStan 'method.notFound'. --- classes/PluginHost.php | 3 --- 1 file changed, 3 deletions(-) (limited to 'classes') diff --git a/classes/PluginHost.php b/classes/PluginHost.php index 5f1d97f53..ec47e6249 100644 --- a/classes/PluginHost.php +++ b/classes/PluginHost.php @@ -143,9 +143,6 @@ class PluginHost { /** @see Plugin::hook_format_article() */ const HOOK_FORMAT_ARTICLE = "hook_format_article"; - /** @see Plugin::hook_format_article_cdm() */ - const HOOK_FORMAT_ARTICLE_CDM = "hook_format_article_cdm"; - /** @see Plugin::hook_feed_basic_info() */ const HOOK_FEED_BASIC_INFO = "hook_feed_basic_info"; -- cgit v1.2.3-54-g00ecf From 1c9fddd75713ff8a6e4ecb213953f2394c0a1496 Mon Sep 17 00:00:00 2001 From: wn_ Date: Sun, 27 Apr 2025 15:05:28 +0000 Subject: Add a PHPStan ignore for a non-issue in 'UrlHelper::fetch()'. --- classes/UrlHelper.php | 1 + 1 file changed, 1 insertion(+) (limited to 'classes') diff --git a/classes/UrlHelper.php b/classes/UrlHelper.php index ad01266ee..d31dcaa3c 100644 --- a/classes/UrlHelper.php +++ b/classes/UrlHelper.php @@ -432,6 +432,7 @@ class UrlHelper { return false; } + // @phpstan-ignore argument.type (prior validation ensures the host value exists) self::$fetch_effective_ip_addr = gethostbyname(parse_url(self::$fetch_effective_url, PHP_URL_HOST)); if (!self::$fetch_effective_ip_addr || str_starts_with(self::$fetch_effective_ip_addr, '127.')) { -- cgit v1.2.3-54-g00ecf From f097c5ed97671f66be71e52c13917c23528ba308 Mon Sep 17 00:00:00 2001 From: wn_ Date: Sun, 27 Apr 2025 15:13:15 +0000 Subject: Remove an unnecessary session UID existence check in 'UserHelper::authenticate()'. PHPStan 'if.alwaysTrue' --- classes/UserHelper.php | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'classes') diff --git a/classes/UserHelper.php b/classes/UserHelper.php index c0540258f..15063c33f 100644 --- a/classes/UserHelper.php +++ b/classes/UserHelper.php @@ -181,10 +181,8 @@ class UserHelper { $_SESSION["last_login_update"] = time(); } - if ($_SESSION["uid"]) { - startup_gettext(); - self::load_user_plugins($_SESSION["uid"]); - } + startup_gettext(); + self::load_user_plugins($_SESSION["uid"]); } } -- cgit v1.2.3-54-g00ecf