From 38f439708cd78b224978c3d3d9cd85d40a9f9c04 Mon Sep 17 00:00:00 2001 From: Andrew Dolgov Date: Fri, 2 Aug 2013 16:20:39 +0400 Subject: rollback current transaction before trying to report SQL query errors, properly save database error messages when logging query errors --- classes/db/pgsql.php | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'classes/db/pgsql.php') diff --git a/classes/db/pgsql.php b/classes/db/pgsql.php index 4d860790b..ba37f83a6 100644 --- a/classes/db/pgsql.php +++ b/classes/db/pgsql.php @@ -35,11 +35,14 @@ class Db_Pgsql implements IDb { } function query($query, $die_on_error = true) { - $result = pg_query($query); + $result = @pg_query($this->link, $query); if (!$result) { + $error = @pg_last_error($this->link); + + @pg_query($this->link, "ROLLBACK"); $query = htmlspecialchars($query); // just in case - user_error("Query $query failed: " . ($this->link ? pg_last_error($this->link) : "No connection"), + user_error("Query $query failed: " . ($this->link ? $error : "No connection"), $die_on_error ? E_USER_ERROR : E_USER_WARNING); } return $result; -- cgit v1.2.3-54-g00ecf