diff options
Diffstat (limited to 'classes')
| -rw-r--r-- | classes/feeditem/atom.php | 6 | ||||
| -rwxr-xr-x | classes/feeds.php | 3 | ||||
| -rw-r--r-- | classes/pluginhost.php | 3 | ||||
| -rwxr-xr-x | classes/pref/feeds.php | 42 | ||||
| -rw-r--r-- | classes/rssutils.php | 63 |
5 files changed, 74 insertions, 43 deletions
diff --git a/classes/feeditem/atom.php b/classes/feeditem/atom.php index 76d85b2a2..77cd448b8 100644 --- a/classes/feeditem/atom.php +++ b/classes/feeditem/atom.php @@ -69,7 +69,7 @@ class FeedItem_Atom extends FeedItem_Common { $child = $content->childNodes->item($i); if ($child->hasChildNodes()) { - return $this->doc->saveXML($child); + return $this->doc->saveHTML($child); } } } @@ -89,7 +89,7 @@ class FeedItem_Atom extends FeedItem_Common { $child = $content->childNodes->item($i); if ($child->hasChildNodes()) { - return $this->doc->saveXML($child); + return $this->doc->saveHTML($child); } } } @@ -197,4 +197,4 @@ class FeedItem_Atom extends FeedItem_Common { return $encs; } -}
\ No newline at end of file +} diff --git a/classes/feeds.php b/classes/feeds.php index b0fa85f9e..99eb0fbf2 100755 --- a/classes/feeds.php +++ b/classes/feeds.php @@ -1530,7 +1530,6 @@ class Feeds extends Handler_Protected { "SELECT id FROM ttrss_feeds WHERE feed_url = '$url' AND owner_uid = ".$_SESSION["uid"]); - $auth_pass_encrypted = 'false'; $auth_pass = db_escape_string($auth_pass); if (db_num_rows($result) == 0) { @@ -1538,7 +1537,7 @@ class Feeds extends Handler_Protected { "INSERT INTO ttrss_feeds (owner_uid,feed_url,title,cat_id, auth_login,auth_pass,update_method,auth_pass_encrypted) VALUES ('".$_SESSION["uid"]."', '$url', - '[Unknown]', $cat_qpart, '$auth_login', '$auth_pass', 0, $auth_pass_encrypted)"); + '[Unknown]', $cat_qpart, '$auth_login', '$auth_pass', 0, false)"); $result = db_query( "SELECT id FROM ttrss_feeds WHERE feed_url = '$url' diff --git a/classes/pluginhost.php b/classes/pluginhost.php index afe4da49e..571c30fb6 100644 --- a/classes/pluginhost.php +++ b/classes/pluginhost.php @@ -54,6 +54,7 @@ class PluginHost { const HOOK_ENCLOSURE_ENTRY = 33; const HOOK_FORMAT_ARTICLE = 34; const HOOK_FORMAT_ARTICLE_CDM = 35; + const HOOK_FEED_BASIC_INFO = 36; const KIND_ALL = 1; const KIND_SYSTEM = 2; @@ -436,4 +437,4 @@ class PluginHost { function get_filter_actions() { return $this->plugin_actions; } -}
\ No newline at end of file +} diff --git a/classes/pref/feeds.php b/classes/pref/feeds.php index b0f82e7e4..a86a1af94 100755 --- a/classes/pref/feeds.php +++ b/classes/pref/feeds.php @@ -634,16 +634,8 @@ class Pref_Feeds extends Handler_Protected { ((FORCE_ARTICLE_PURGE == 0) ? "" : 'disabled="1"')); print "</div>"; - print "<div class=\"dlgSec\">".__("Authentication")."</div>"; - print "<div class=\"dlgSecCont\">"; $auth_login = htmlspecialchars($this->dbh->fetch_result($result, 0, "auth_login")); - - print "<input dojoType=\"dijit.form.TextBox\" id=\"feedEditDlg_login\" - placeHolder=\"".__("Login")."\" - autocomplete=\"new-password\" - name=\"auth_login\" value=\"$auth_login\"><hr/>"; - $auth_pass = $this->dbh->fetch_result($result, 0, "auth_pass"); if ($auth_pass_encrypted && function_exists("mcrypt_decrypt")) { @@ -652,6 +644,18 @@ class Pref_Feeds extends Handler_Protected { } $auth_pass = htmlspecialchars($auth_pass); + $auth_enabled = $auth_login !== '' || $auth_pass !== ''; + + $auth_style = $auth_enabled ? '' : 'display: none'; + print "<div id='feedEditDlg_loginContainer' style='$auth_style'>"; + print "<div class=\"dlgSec\">".__("Authentication")."</div>"; + print "<div class=\"dlgSecCont\">"; + + print "<input dojoType=\"dijit.form.TextBox\" id=\"feedEditDlg_login\" + placeHolder=\"".__("Login")."\" + autocomplete=\"new-password\" + name=\"auth_login\" value=\"$auth_login\"><hr/>"; + print "<input dojoType=\"dijit.form.TextBox\" type=\"password\" name=\"auth_pass\" autocomplete=\"new-password\" @@ -662,7 +666,14 @@ class Pref_Feeds extends Handler_Protected { ".__('<b>Hint:</b> you need to fill in your login information if your feed requires authentication, except for Twitter feeds.')." </div>"; - print "</div>"; + print "</div></div>"; + + $auth_checked = $auth_enabled ? 'checked' : ''; + print "<div style=\"clear : both\"> + <input type=\"checkbox\" $auth_checked name=\"need_auth\" dojoType=\"dijit.form.CheckBox\" id=\"feedEditDlg_loginCheck\" + onclick='checkboxToggleElement(this, \"feedEditDlg_loginContainer\")'> + <label for=\"feedEditDlg_loginCheck\">". + __('This feed requires authentication.')."</div>"; print '</div><div dojoType="dijit.layout.ContentPane" title="'.__('Options').'">'; @@ -971,7 +982,6 @@ class Pref_Feeds extends Handler_Protected { $feed_language = $this->dbh->escape_string(trim($_POST["feed_language"])); - $auth_pass_encrypted = 'false'; $auth_pass = $this->dbh->escape_string($auth_pass); if (get_pref('ENABLE_FEED_CATS')) { @@ -988,6 +998,10 @@ class Pref_Feeds extends Handler_Protected { } if (!$batch) { + if ($_POST["need_auth"] !== 'on') { + $auth_login = ''; + $auth_pass = ''; + } $result = db_query("SELECT feed_url FROM ttrss_feeds WHERE id = " . $feed_id); $orig_feed_url = db_fetch_result($result, 0, "feed_url"); @@ -1001,7 +1015,7 @@ class Pref_Feeds extends Handler_Protected { purge_interval = '$purge_intl', auth_login = '$auth_login', auth_pass = '$auth_pass', - auth_pass_encrypted = $auth_pass_encrypted, + auth_pass_encrypted = false, private = $private, cache_images = $cache_images, hide_images = $hide_images, @@ -1055,8 +1069,7 @@ class Pref_Feeds extends Handler_Protected { break; case "auth_pass": - $qpart = "auth_pass = '$auth_pass' AND - auth_pass_encrypted = $auth_pass_encrypted"; + $qpart = "auth_pass = '$auth_pass', auth_pass_encrypted = false"; break; case "private": @@ -1857,7 +1870,6 @@ class Pref_Feeds extends Handler_Protected { "SELECT id FROM ttrss_feeds WHERE feed_url = '$feed' AND owner_uid = ".$_SESSION["uid"]); - $auth_pass_encrypted = 'false'; $pass = $this->dbh->escape_string($pass); if ($this->dbh->num_rows($result) == 0) { @@ -1865,7 +1877,7 @@ class Pref_Feeds extends Handler_Protected { "INSERT INTO ttrss_feeds (owner_uid,feed_url,title,cat_id,auth_login,auth_pass,update_method,auth_pass_encrypted) VALUES ('".$_SESSION["uid"]."', '$feed', - '[Unknown]', $cat_qpart, '$login', '$pass', 0, $auth_pass_encrypted)"); + '[Unknown]', $cat_qpart, '$login', '$pass', 0, false)"); } $this->dbh->query("COMMIT"); diff --git a/classes/rssutils.php b/classes/rssutils.php index 460709f05..d6dfc724e 100644 --- a/classes/rssutils.php +++ b/classes/rssutils.php @@ -205,9 +205,11 @@ class RSSUtils { $feed = db_escape_string($feed); - $result = db_query("SELECT feed_url,auth_pass,auth_login,auth_pass_encrypted + $result = db_query("SELECT owner_uid,feed_url,auth_pass,auth_login,auth_pass_encrypted FROM ttrss_feeds WHERE id = '$feed'"); + $owner_uid = db_fetch_result($result, 0, "owner_uid"); + $auth_pass_encrypted = sql_bool_to_bool(db_fetch_result($result, 0, "auth_pass_encrypted")); @@ -221,42 +223,59 @@ class RSSUtils { $fetch_url = db_fetch_result($result, 0, "feed_url"); - $feed_data = fetch_file_contents($fetch_url, false, - $auth_login, $auth_pass, false, - FEED_FETCH_TIMEOUT, - 0); - - global $fetch_curl_used; + $pluginhost = new PluginHost(); + $user_plugins = get_pref("_ENABLED_PLUGINS", $owner_uid); - if (!$fetch_curl_used) { - $tmp = @gzdecode($feed_data); + $pluginhost->load(PLUGINS, PluginHost::KIND_ALL); + $pluginhost->load($user_plugins, PluginHost::KIND_USER, $owner_uid); + $pluginhost->load_data(); - if ($tmp) $feed_data = $tmp; + $basic_info = array(); + foreach ($pluginhost->get_hooks(PluginHost::HOOK_FEED_BASIC_INFO) as $plugin) { + $basic_info = $plugin->hook_feed_basic_info($basic_info, $fetch_url, $owner_uid, $feed, $auth_login, $auth_pass); } - $feed_data = trim($feed_data); + if (!$basic_info) { + $feed_data = fetch_file_contents($fetch_url, false, + $auth_login, $auth_pass, false, + FEED_FETCH_TIMEOUT, + 0); - $rss = new FeedParser($feed_data); - $rss->init(); + global $fetch_curl_used; - if (!$rss->error()) { + if (!$fetch_curl_used) { + $tmp = @gzdecode($feed_data); + + if ($tmp) $feed_data = $tmp; + } + + $feed_data = trim($feed_data); + + $rss = new FeedParser($feed_data); + $rss->init(); + if (!$rss->error()) { + $basic_info = array( + 'title' => db_escape_string(mb_substr($rss->get_title(), 0, 199)), + 'site_url' => db_escape_string(mb_substr(rewrite_relative_url($fetch_url, $rss->get_link()), 0, 245)) + ); + } + } + + if ($basic_info && is_array($basic_info)) { $result = db_query("SELECT title, site_url FROM ttrss_feeds WHERE id = '$feed'"); $registered_title = db_fetch_result($result, 0, "title"); $orig_site_url = db_fetch_result($result, 0, "site_url"); - $site_url = db_escape_string(mb_substr(rewrite_relative_url($fetch_url, $rss->get_link()), 0, 245)); - $feed_title = db_escape_string(mb_substr($rss->get_title(), 0, 199)); - - if ($feed_title && (!$registered_title || $registered_title == "[Unknown]")) { + if ($basic_info['title'] && (!$registered_title || $registered_title == "[Unknown]")) { db_query("UPDATE ttrss_feeds SET - title = '$feed_title' WHERE id = '$feed'"); + title = '${basic_info['title']}' WHERE id = '$feed'"); } - if ($site_url && $orig_site_url != $site_url) { + if ($basic_info['site_url'] && $orig_site_url != $basic_info['site_url']) { db_query("UPDATE ttrss_feeds SET - site_url = '$site_url' WHERE id = '$feed'"); + site_url = '${basic_info['site_url']}' WHERE id = '$feed'"); } } } @@ -1520,4 +1539,4 @@ class RSSUtils { -}
\ No newline at end of file +} |