add deprecation notice for sql_random_function()

2 files changed, 2 insertions, 3 deletions

diff --git a/classes/Db.php b/classes/Db.php
index 6310d11e3..872c6b351 100644
--- a/classes/Db.php
+++ b/classes/Db.php
@@ -71,6 +71,7 @@ class Db {
 		return self::$instance->pdo;
 	}
 
+	/** @deprecated usages should be replaced with `RANDOM()` */
 	public static function sql_random_function(): string {
 		return "RANDOM()";
 	}
diff --git a/classes/RPC.php b/classes/RPC.php
index bad51e4aa..031bef509 100644
--- a/classes/RPC.php
+++ b/classes/RPC.php
@@ -269,8 +269,6 @@ class RPC extends Handler_Protected {
 		$updstart_thresh_qpart = 'AND (last_update_started IS NULL OR '
 			. Db::past_comparison_qpart('last_update_started', '<', 5, 'minute') . ')';
 
-		$random_qpart = Db::sql_random_function();
-
 		$pdo = Db::pdo();
 
 		// we could be invoked from public.php with no active session
@@ -290,7 +288,7 @@ class RPC extends Handler_Protected {
 				$owner_check_qpart
 				$update_limit_qpart
 				$updstart_thresh_qpart
-			ORDER BY $random_qpart LIMIT 30";
+			ORDER BY RANDOM() LIMIT 30";
 
 		$res = $pdo->query($query);